Skip to content

Conversation

@tspiller
Copy link
Collaborator

@tspiller tspiller commented Mar 14, 2025

Description

When attempting to paste a composite part into a non-composite binding both Input Manager and Input System end up throwing errors as it uses a best guess trying to find the closest applicable index it can paste into. When pasting directly into a binding nothing is found, so nothing is pasted, but attempts to return the new selection/last pasted element anyway.

This fix skips returning the new selections when nothing was actually pasted.

I attempted to look into disabling paste completely in this scenario but HasPastableClipboardData is passed the InputBinding type and I couldn't find a simple way to distinguish between composites and bindings at this point.

Testing status & QA

Tested in Input Manager and Input System (old and new UI) and confirmed that there are no longer errors in either.

Overall Product Risks

  • Complexity: 0
  • Halo Effect: 0

Comments to reviewers

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@tspiller tspiller requested a review from ritamerkl March 17, 2025 12:59
@tspiller tspiller marked this pull request as ready for review March 17, 2025 12:59
@ritamerkl ritamerkl requested a review from Pauliusd01 March 17, 2025 13:12
@ritamerkl
Copy link
Collaborator

Adding Paulius for QA

@tspiller tspiller merged commit b2a2329 into develop Mar 19, 2025
110 checks passed
@tspiller tspiller deleted the isxb-757-copy-composite-into-binding branch March 19, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants